Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt AlpakkaKafkaContainer to Testcontainers 1.15 #1225

Closed
ennru opened this issue Oct 9, 2020 · 5 comments
Closed

Adapt AlpakkaKafkaContainer to Testcontainers 1.15 #1225

ennru opened this issue Oct 9, 2020 · 5 comments

Comments

@ennru
Copy link
Member

ennru commented Oct 9, 2020

The upcoming Testcontainers 1.15 version brings important improvements to the framework.
https://github.com/testcontainers/testcontainers-java/releases

As AlpakkaKafkaContainer replaces KafkaContainer it needs to be updated with the latest changes from Testcontainers. Specifically, testcontainers/testcontainers-java#3293 adapts it to work with the Kafka broker bundled in Confluent Platform 6.0.0.

@agemooij
Copy link

agemooij commented Nov 8, 2020

Any idea when this issue can be fixed and released?

All our Kafka tests started failing on my machine after I innocently said yes to a new stable release (2.5.0.0) of the docker for Mac distro. This triggered an issue in testcontainers that causes it to fail catastrophically.

I'll try downgrading my docker client to pre-2.4 for now but it would be great if this incompatibility could be fixed ASAP.

@ennru ennru modified the milestones: 2.1.0-RC1, 3.0.0 Nov 9, 2020
@ennru
Copy link
Member Author

ennru commented Nov 9, 2020

With #1257 Alpakka Kafka uses Testcontainers 1.15.0.

@agemooij I would expect overriding the Testcontainers version in 3.0.0-M1 works. We'd want to progress a bit more before releasing M2.

@ennru ennru closed this as completed Nov 9, 2020
@agemooij
Copy link

agemooij commented Nov 9, 2020

OK, thanks! I'll try that. The Docker for Mac downgrade worked for me as well but I assume quite a few people will start running into this as they upgrade their systems so probably good to clearly mention it in the release notes and perhaps even as a known issue for the 2.0 releases.

@agemooij
Copy link

agemooij commented Nov 9, 2020

@ennru I guess you meant the 2.1.0-M1 release? Or are you going to relabel it to 3.0 for M2?

@ennru ennru modified the milestones: 3.0.0, 2.1.0-RC1 Nov 9, 2020
@ennru
Copy link
Member Author

ennru commented Nov 9, 2020

My bad, I mixed things up with main Alpakka.
The upcoming Alpakka Kafka version is 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants