AWS S3: Empty exception issue #1589 #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinAman
force-pushed
the
empty_exception
branch
3 times, most recently
from
fa1b31f
to
07188e0
Compare
Closed
2m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Right now, when alpakka receives an empty message it throws S3Exception but doesn't include any clue for the user on how to fix it. As all communication with S3 is just standard Http alpakka has the response code but ignores it before calling S3Exception's constructor.
Purpose of this PR is to include more information in exception message
References
References #1589
Changes
Added a response code to exception's constructor to later be displayed for the user.