Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Akka's setup operator #1765

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Use Akka's setup operator #1765

merged 3 commits into from
Jun 24, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Jun 20, 2019

Purpose

Use Akka's setup operator instead of local copies in multiple Alpakka connectors.

References

See #1713

Changes

  • one commit to replace setup
  • one commit to update reformatted Java code

Background Context

Alpakka invented the setup operator which became part of Akka with release 2.5.23.

@ennru ennru added this to the 1.0.3 milestone Jun 20, 2019
2m
2m approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. MiMa's furious, but that is all in the impl package.

@ennru
Copy link
Member Author

ennru commented Jun 24, 2019

Failure was #1770

@ennru ennru merged commit 1d9899c into akka:master Jun 24, 2019
@ennru ennru deleted the drop-setup branch June 24, 2019 04:57
@ennru ennru mentioned this pull request Jun 25, 2019
Closed
3 tasks
@ennru ennru removed the p:hbase label Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
p:amqp p:aws-s3 p:cassandra p:couchbase p:elasticsearch p:google-cloud-pub-sub-grpc p:google-fcm p:hdfs p:jms p:kudu p:mongodb p:mqtt p:orientdb p:reference
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ennru @2m