SQS: allow sub-types in the Java API; improve tests #2032

ennru · 2019-11-25T15:37:15Z

Purpose

Change the type in the Java API of the batch operations to allow for sub-types of Iterable so it composes more nicely with eg. grouped.

Improved closing the SQS client in the tests
Use Alpakka to publish to the topic in SqsSourceTest to avoid too many parallel HTTP connections when tests run on Travis

sqs/src/test/java/akka/stream/alpakka/sqs/javadsl/BaseSqsTest.java

seglo

LGTM

SQS: allow sub-types in the Java API; improve tests

70d4994

probot-autolabeler bot added the p:aws-sqs label Nov 25, 2019

ennru added this to Incoming Issues and PRs in Akka streaming via automation Nov 25, 2019

ennru moved this from Incoming Issues and PRs to In progress in Akka streaming Nov 25, 2019

MiMa exclusions

b6d3120

ennru moved this from In progress to Ready for review in Akka streaming Nov 26, 2019

seglo reviewed Nov 28, 2019

View reviewed changes

sqs/src/test/java/akka/stream/alpakka/sqs/javadsl/BaseSqsTest.java Show resolved Hide resolved

ennru moved this from Ready for review to Review in progress in Akka streaming Nov 29, 2019

seglo approved these changes Nov 29, 2019

View reviewed changes

Akka streaming automation moved this from Review in progress to Reviewer approved Nov 29, 2019

seglo merged commit 35c69ce into akka:master Nov 29, 2019

Akka streaming automation moved this from Reviewer approved to Done Nov 29, 2019

ennru deleted the sqs-java-type branch April 21, 2023 07:53