Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS: close sessions in postStop #2048

Merged
merged 6 commits into from
Dec 16, 2019
Merged

JMS: close sessions in postStop #2048

merged 6 commits into from
Dec 16, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Dec 13, 2019 •
edited
Loading

Purpose

Close JMS sessions on stage stop.

Changes

(See commits)

  • Isolate the access to sessions within JmsConnector.
  • Switch some tests to use a shared JMS broker with by using random queue names
  • Close sessions in finishStop which is called from postStop

Background Context

While exploring possible solutions to #2039 I noticed the JMS sessions are not properly closed in more scenarios.

@ennru
Copy link
Member Author

ennru commented Dec 13, 2019

@andreas-schroeder Would be great if you can help me to come up with a good solution to #2039.

@ennru ennru added this to Incoming Issues and PRs in Akka streaming via automation Dec 16, 2019
@ennru ennru changed the title JMS: isolate session handling JMS: close sessions in postStop Dec 16, 2019
@ennru ennru moved this from Incoming Issues and PRs to Ready for review in Akka streaming Dec 16, 2019
Akka streaming automation moved this from Ready for review to Reviewer approved Dec 16, 2019
seglo
seglo approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit 254dab0 into akka:master Dec 16, 2019
Akka streaming automation moved this from Reviewer approved to Done Dec 16, 2019
@ennru ennru deleted the jms-session-close branch December 16, 2019 14:43
@ennru ennru mentioned this pull request Dec 16, 2019
Closed
@ennru ennru mentioned this pull request Dec 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees
No one assigned
Labels
p:jms
Projects
No open projects
Akka streaming
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ennru @seglo