Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated akka and akka-http versions #2071

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

touchdown
Copy link
Contributor

@touchdown touchdown commented Jan 4, 2020

Purpose

Update akka version from 2.5.26 to 2.5.27
Update akka-http version from 10.1.10 to 10.1.11

References

Relevant issue #2070

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Jan 4, 2020
@touchdown touchdown changed the title updated akka version from 2.5.26 to 2.5.27 updated akka and akka-http versions Jan 4, 2020
@touchdown
Copy link
Contributor Author

the build failed to fetch deps that are present on maven, can we retry the build please?

@seglo
Copy link
Member

seglo commented Jan 6, 2020

I created #2072 to update akka-http before I saw this PR. Since you created yours first we'll go with it :)

We were having trouble with build caches. I cleared them and restarted the build.

@seglo seglo mentioned this pull request Jan 6, 2020
@seglo
Copy link
Member

seglo commented Jan 6, 2020

For reference

The version of akka-http includes a fix to make transient connection error exception messages more clear. akka/akka-http@d46130d

@touchdown
Copy link
Contributor Author

touchdown commented Jan 7, 2020

it failed on 3 separate tests, 2 of which pertains to timeouts and one on docs? docs.javadsl.SlickTest.testFlowWithPassThroughKafkaExample(SlickTest.java:272)

@seglo
Copy link
Member

seglo commented Jan 7, 2020

These are all transient failures related to slow processing capabilities of the travis build. The build looks good otherwise.

Transient failures

@seglo seglo added this to Incoming Issues and PRs in Akka streaming via automation Jan 7, 2020
@seglo seglo added this to the 2.0.0 milestone Jan 7, 2020
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Akka streaming automation moved this from Incoming Issues and PRs to Reviewer approved Jan 7, 2020
@seglo seglo merged commit d6a4001 into akka:master Jan 7, 2020
Akka streaming automation moved this from Reviewer approved to Done Jan 7, 2020
@ennru
Copy link
Member

ennru commented Jan 11, 2020

I don't see compelling reasons for why Alpakka should upgrade these dependencies at this time. We should maybe be more clear on that users should control and upgrade their Akka and Akka HTTP versions independently of Alpakka. This is even more relevant during the Akka 2.5/2.6 transition.

@ennru
Copy link
Member

ennru commented Jan 13, 2020

@seglo and I discussed this more, as we are approaching Alpakka 2.0 it is actually a good time to upgrade Akka things.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@huntc
Copy link
Contributor

huntc commented Jan 23, 2020

UPDATE: Irrelevant - ignore this - turned out to be a bug in my project.

I'm unsure if this is relevant, but I upgraded my projects today as follows:

akka  2.5.23 -> 2.5.27
akkaHttp 10.1.8 -> 10.1.11
alpakka 1.1.1+30-c1934ed4 -> 1.1.2

I'm experiencing some weirdness and I'm wondering if it is due to the 1.1 branch of Alpakka being left on older versions of Akka. I did get the warning:

ManifestInfo - Detected possible incompatible versions on the classpath. Please note that a given Akka version MUST be the same across all modules of Akka that you are using, e.g. if you use [2.5.27] all other modules that are released together MUST be of the same version. Make sure you're using a compatible set of libraries. Possibly conflicting versions [2.5.27, 2.5.23] in libraries [akka-protobuf:2.5.27, akka-actor-typed:2.5.23, akka-actor:2.5.27, akka-slf4j:2.5.27, akka-stream:2.5.27, akka-stream-typed:2.5.23]

I'm now trying another release of my project with Alpakka as 2.0.0-M2 given the closer proximity of Akka releases, but if that works then that would mean that Alpakka 1.1 might need an upgrade of its Akka dependencies. I shall report back.

@ennru
Copy link
Member

ennru commented Jan 23, 2020

You need to pull up the transitive Akka dependencies (akka-actor-typed, akka-actor-typed) to the same Akka version.

@huntc
Copy link
Contributor

huntc commented Jan 23, 2020

Thanks. Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpakka-itself dependency-change For PRs changing the version of a dependency.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants