-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated akka and akka-http versions #2071
Conversation
the build failed to fetch deps that are present on maven, can we retry the build please? |
I created #2072 to update akka-http before I saw this PR. Since you created yours first we'll go with it :) We were having trouble with build caches. I cleared them and restarted the build. |
For reference
|
it failed on 3 separate tests, 2 of which pertains to timeouts and one on docs? |
These are all transient failures related to slow processing capabilities of the travis build. The build looks good otherwise. Transient failures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't see compelling reasons for why Alpakka should upgrade these dependencies at this time. We should maybe be more clear on that users should control and upgrade their Akka and Akka HTTP versions independently of Alpakka. This is even more relevant during the Akka 2.5/2.6 transition. |
@seglo and I discussed this more, as we are approaching Alpakka 2.0 it is actually a good time to upgrade Akka things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
UPDATE: Irrelevant - ignore this - turned out to be a bug in my project. I'm unsure if this is relevant, but I upgraded my projects today as follows:
I'm experiencing some weirdness and I'm wondering if it is due to the 1.1 branch of Alpakka being left on older versions of Akka. I did get the warning:
I'm now trying another release of my project with Alpakka as 2.0.0-M2 given the closer proximity of Akka releases, but if that works then that would mean that Alpakka 1.1 might need an upgrade of its Akka dependencies. I shall report back. |
You need to pull up the transitive Akka dependencies (akka-actor-typed, akka-actor-typed) to the same Akka version. |
Thanks. Got it. |
Purpose
Update akka version from 2.5.26 to 2.5.27
Update akka-http version from 10.1.10 to 10.1.11
References
Relevant issue #2070