Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Cloud Storage: Retry when any 500 level server error is… #2082

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Google Cloud Storage: Retry when any 500 level server error is… #2082

merged 1 commit into from
Jan 13, 2020

Conversation

seglo
Copy link
Member

@seglo seglo commented Jan 10, 2020 •
edited by ennru
Loading

Purpose

Enables retries for any akka-http known server error.

References

Changes

  • Pattern match any ServerError (5xx) instead of just StatusCode.InternalServerError (500)

@seglo seglo mentioned this pull request Jan 10, 2020
Closed
@seglo seglo added this to Incoming Issues and PRs in Akka streaming via automation Jan 10, 2020
@seglo seglo moved this from Incoming Issues and PRs to Ready for review in Akka streaming Jan 10, 2020
@ennru ennru changed the title Retry when any 500 level server error is returned Google Cloud Storage: Retry when any 500 level server error is returned Jan 13, 2020
Akka streaming automation moved this from Ready for review to Reviewer approved Jan 13, 2020
ennru
ennru approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even if it didn't solve the problems reported in #2057 and #2080.

@ennru ennru added this to the 2.0.0 milestone Jan 13, 2020
@ennru ennru changed the title Google Cloud Storage: Retry when any 500 level server error is returned Google Cloud Storage: Retry when any 500 level server error is… Jan 13, 2020
@ennru ennru merged commit 3e02963 into akka:master Jan 13, 2020
Akka streaming automation moved this from Reviewer approved to Done Jan 13, 2020
@francisdb francisdb mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:google-cloud-storage
Projects
No open projects
Akka streaming
  
Done
Milestone
2.0.0-M3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seglo @ennru