MQTT streaming: target Akka 2.6 #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
dependency-change
|
Watch out for the Alpakka testkit dependency brought in by |
|
(failure is scaladoc generation, looking into that...) |
raboof
force-pushed
the
mqttStreamingForAkka26
branch
2 times, most recently
from
07550c3
to
b34abc7
Compare
|
The failure is not new to the branch #1723 |
ennru
approved these changes
Feb 12, 2020
|
Ah, I think it should state Akka 2.6 only, instead. |
|
it seems obvious from the dependency table. Do you think we should spell it out further?
|
|
Yes, it is an exception to the rule in Alpakka. |
I didn't add a new note that it now needs Akka 2.6: that should be obvious from the dependency tree.
raboof
force-pushed
the
mqttStreamingForAkka26
branch
from
f59a8b3
to
3e8b157
Compare
ennru
changed the title
This was referenced Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still failing one test: "MqttSessionSpec: MQTT client connector should receive a QoS 1 publication from a subscribed topic and ack it and then ack it again"
References #2097