Fix Java Unit Test docs example in Unix Domain Sockets #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build failure should be fixed by #2123 |
raboof
approved these changes
Feb 3, 2020
| .map(s -> s + "!!!\n") | ||
| .map(ByteString::fromString); | ||
| // server logic ... | ||
| // #outgoingConnection |
There was a problem hiding this comment.
Good to keep the actual implementation out of the docs
| // #outgoingConnection | ||
| ByteString sendBytes = ByteString.fromString("Hello"); |
There was a problem hiding this comment.
(this line could be moved down to below the part that makes it into the docs)
seglo
force-pushed
the
seglo/java-unix-domain-socket-test
branch
from
1f92892
to
e1547ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lone Java test in unix-domain-socket used for docs has always failed, but we never noticed it because we didn't block on stream completion before the test completed. The blocking was added #2040 (https://github.com/akka/alpakka/pull/2040/files#r368017011), but the test failure got confused with a transient test failure and the PR was merged.
Changes
jnr-unixsocketwill create the socket files on our behalf, if the file already exists then we'll observe anAddress in useexception (https://travis-ci.com/akka/alpakka/jobs/277967218#L358)ByteStringlike the Scala docs example does.