Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB: replaceOne operation #2187

Merged
merged 7 commits into from
Mar 19, 2020
Merged

Conversation

jewertow
Copy link
Contributor

@jewertow jewertow commented Mar 10, 2020

References #2100

@ennru ennru changed the title Support operation replaceOne (#2100). MongoDB: replaceOne operation Mar 11, 2020
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're on the right track 👍

@jewertow
Copy link
Contributor Author

jewertow commented Mar 12, 2020

@seglo what do you think about using in tests and docs object DomainObject(https://github.com/akka/alpakka/pull/2187/files#diff-670af5a1ee8a19bd56d7ed678837ecc6) instead of the existing Number.
In case of replaceOne object Number is useless.
Do you want to have all tests and examples using the DomainObject or only replaceOne?

In my opinion it is a little bit confusing that we declare the class Number with only one field _id and then we update fields value and updatedValue.
If you want to have unified tests and examples I can change it and prepare next pull request.
If you think that the DomainObject is not a good example you can suggest something else.

@jewertow
Copy link
Contributor Author

Ok, the implementation is done. You can review the code.

@seglo
Copy link
Member

seglo commented Mar 14, 2020

@jewertow Thanks. I'm on vacation ATM, but @ennru or someone else from the team will take a look next week.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 2339f3e into akka:master Mar 19, 2020
@ennru
Copy link
Member

ennru commented Mar 19, 2020

Thank you for another great contribution!

@ennru ennru mentioned this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants