File: TAR archive generation #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
choffmeister
force-pushed
the
tarball-flow
branch
2 times, most recently
from
448c2f6
to
3e090da
Compare
choffmeister
force-pushed
the
tarball-flow
branch
4 times, most recently
from
12e5794
to
2e9c67b
Compare
choffmeister
force-pushed
the
tarball-flow
branch
from
2e9c67b
to
a04656d
Compare
ennru
reviewed
Mar 30, 2020
file/src/main/scala/akka/stream/alpakka/file/impl/archive/TarArchiveHeader.scala
Outdated
Show resolved
Hide resolved
file/src/main/scala/akka/stream/alpakka/file/impl/archive/TarArchiveHeader.scala
Outdated
Show resolved
Hide resolved
file/src/main/scala/akka/stream/alpakka/file/impl/archive/TarArchiveManager.scala
Outdated
Show resolved
Hide resolved
file/src/main/scala/akka/stream/alpakka/file/scaladsl/Archive.scala
Outdated
Show resolved
Hide resolved
choffmeister
force-pushed
the
tarball-flow
branch
from
53a0464
to
b493830
Compare
|
@ennru Thanks for all your feedback. Should now all be integrated in this PR. A little extra change that I made: I renamed |
|
Thank you! Great addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides very similar functionality to
Archive.zip(), just for uncompressed tarballs. The biggest benefit compared to using the zip flow is, that this does not rely on any blocking Java IO APIs.References #2034