File: TAR archive reader #2268
Merged
File: TAR archive reader #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
Apr 21, 2020
| @@ -27,4 +27,10 @@ object Archive { | |||
| def tar(): Flow[(TarArchiveMetadata, Source[ByteString, _]), ByteString, NotUsed] = | |||
| TarArchiveManager.tarFlow() | |||
|
|
|||
| /** | |||
| * Parse incoming `ByteString`s into tar file entries and sources for the file contents. | |||
| * The file contents sources MUST be consumed to progress reading the file. | |||
There was a problem hiding this comment.
Hmm, this is kinda dangerous - uses like bytes.via(tarReader).take(100).foreach(_.runWith(Sink.ignore)) could stall the stream.
I seem to remember we have similar problems in processing multipart file uploads in Akka HTTP, but can't find a reference right now.
I don't see how we could make an API that avoids this, though, so perhaps this comment is sufficient.
raboof
approved these changes
Apr 23, 2020
|
Hey @ennru, given your work on this pull request here, any chance you also add a ZIP archive reader? |
|
I have no plans for that at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reading of tar-formatted streams of
ByteStrings.Inspired by the recent addition of writing tar in #2241 by @choffmeister.
TarReaderStageTarArchiveEntryByteStringhandling inTarArchiveEntryheader creationTODO
SubSourceOutlet