Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kinesis: Small cleanup #2299

Merged
merged 1 commit into from
May 7, 2020
Merged

Kinesis: Small cleanup #2299

merged 1 commit into from
May 7, 2020

Conversation

YikSanChan
Copy link
Contributor

References #xxxx

@YikSanChan
Copy link
Contributor Author

@aserrallerios Do you mind reviewing this? Thanks!

@YikSanChan
Copy link
Contributor Author

@ennru Got Albert's approval, do you mind taking a look?

ennru
ennru approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 2.0.1 milestone May 7, 2020
@ennru ennru changed the title Small cleanup Kinesis: Small cleanup May 7, 2020
@ennru ennru merged commit c61e8c3 into akka:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

@aserrallerios aserrallerios aserrallerios approved these changes

Assignees
No one assigned
Labels
p:kinesis
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YikSanChan @ennru @aserrallerios