Catch and fix more warnings in Java sources #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
p:aws-event-bridge
p:elasticsearch
p:file
p:jms
p:orientdb
labels
|
Needs some |
|
Doesn't like some of your flags, |
|
Oh, I only tried it on JDK 11. |
ennru
force-pushed
the
java-warnings
branch
from
db2b442
to
561417a
Compare
raboof
approved these changes
Oct 23, 2020
| public static Source<Pair<Path, DirectoryChange>, NotUsed> create( | ||
| Path directoryPath, FiniteDuration pollInterval, int maxBufferSize) { | ||
| return Source.fromGraph( | ||
| new DirectoryChangesSource(directoryPath, pollInterval, maxBufferSize, Pair::apply)); | ||
| new DirectoryChangesSource<>(directoryPath, pollInterval, maxBufferSize, Pair::apply)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable more Java linting flags andfix a few warnings detected by it.