Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV: remove materializer #2460

Merged
merged 3 commits into from
Oct 26, 2020
Merged

CSV: remove materializer #2460

merged 3 commits into from
Oct 26, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 26, 2020 •
edited
Loading

Update the CSV tests to pass the actor system instead of an explicit materializer.

References #2054, #2468

@ennru ennru added the p:csv label Oct 26, 2020
ignasi35
ignasi35 reviewed Oct 26, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
ignasi35
ignasi35 approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@ignasi35 ignasi35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left the comment re fatalWarnings above but otherwise LGTM

@ennru ennru merged commit 78f77f7 into akka:master Oct 26, 2020
@ennru ennru deleted the akka-2.6/csv branch October 26, 2020 16:28
@ennru ennru mentioned this pull request Dec 11, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasi35 ignasi35 ignasi35 approved these changes

Assignees
No one assigned
Labels
p:csv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ennru @ignasi35