Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spring-web: Akka 2.6 features #2526

Merged
merged 4 commits into from Nov 18, 2020
Merged

spring-web: Akka 2.6 features #2526

merged 4 commits into from Nov 18, 2020

Conversation

dotbg
Copy link
Contributor

@dotbg dotbg commented Nov 9, 2020 •
edited

References #2499

@ennru
Copy link
Member

ennru commented Nov 11, 2020

This changes the API a bit - which is OK for Alpakka 3.0.

But MiMa requires an exclusion rule. See https://github.com/akka/alpakka/blob/master/CONTRIBUTING.md#binary-compatibility-mimahttps://assets.grammarly.com/emoji/v1/1f628.svg

@dotbg
Copy link
Contributor Author

dotbg commented Nov 11, 2020

This changes the API a bit - which is OK for Alpakka 3.0.

But MiMa requires an exclusion rule. See https://github.com/akka/alpakka/blob/master/CONTRIBUTING.md#binary-compatibility-mima https://assets.grammarly.com/emoji/v1/1f628.svg

@ennru Actually, I can make the API compatible. Should I? May not play well with the fatalWarnings , though

ennru
ennru reviewed Nov 12, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding back a deprecated public AkkaStreamsRegistrar(Materializer mat) which does mat.system and a corresponding getter would be enough, right?
Than go for it.

spring-web/src/main/java/akka/stream/alpakka/spring/web/AkkaStreamsRegistrar.java Show resolved Hide resolved
@dotbg dotbg force-pushed the alpakka-2499 branch 4 times, most recently from 475883e to 2fd5026 Compare November 14, 2020 16:10
@ennru
Copy link
Member

ennru commented Nov 16, 2020

As the signature had to change from ActorMaterializer anyway, I just removed it altogether.

@dotbg
Copy link
Contributor Author

dotbg commented Nov 17, 2020

Rebased the branch.

ennru
ennru approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru changed the title spring-web: Akka 2.6 features (#2499). spring-web: Akka 2.6 features Nov 18, 2020
@ennru ennru merged commit 583b123 into akka:master Nov 18, 2020
@ennru
Copy link
Member

ennru commented Nov 18, 2020

Thank you!

@dotbg
Copy link
Contributor Author

dotbg commented Nov 19, 2020

Thank you, @ennru

@dotbg dotbg deleted the alpakka-2499 branch November 19, 2020 08:56
@seglo seglo added this to the 3.0.0-M1 milestone Feb 10, 2021
@mrooding mrooding mentioned this pull request Mar 9, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
api-change p:spring-web
Projects
None yet
Milestone
3.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotbg @ennru @seglo