Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3: Updated retry logic for S3Stream.signAndRequest #2536

Merged
merged 4 commits into from
Nov 27, 2020
Merged

S3: Updated retry logic for S3Stream.signAndRequest #2536

merged 4 commits into from
Nov 27, 2020

Conversation

bpiper
Copy link
Contributor

@bpiper bpiper commented Nov 26, 2020

References #2535

seglo
seglo reviewed Nov 26, 2020
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just some notes on Settings boilerplate.

s3/src/main/scala/akka/stream/alpakka/s3/settings.scala Show resolved Hide resolved
seglo
seglo reviewed Nov 26, 2020
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor docs updates.

s3/src/main/scala/akka/stream/alpakka/s3/settings.scala Show resolved Hide resolved
@seglo
Copy link
Member

seglo commented Nov 26, 2020

Looks like there's a pile of MiMa exceptions that need to be added for the new APIs. The build should tell you the exact rules you need to add. LMK if you need help creating these.

https://travis-ci.com/github/akka/alpakka/jobs/449213845#L1126

seglo
seglo approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seglo seglo merged commit 2900da5 into akka:master Nov 27, 2020
@seglo
Copy link
Member

seglo commented Nov 27, 2020

Thanks!

@seglo seglo added this to the 3.0.0-M1 milestone Nov 27, 2020
@seglo seglo mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seglo seglo seglo approved these changes

Assignees
No one assigned
Labels
p:aws-s3
Projects
None yet
Milestone
3.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpiper @seglo