Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to paradox theme with new cookie banner #2564

Merged
merged 4 commits into from Feb 1, 2021
Merged

Conversation

johanandren
Copy link
Member

CCPA banner from akka/akka-paradox#135

@johanandren
Copy link
Member Author

johanandren commented Jan 26, 2021

Looks like this is broken/blocked by some stricter verification of links etc. in the newer version.

@seglo
Copy link
Member

seglo commented Jan 26, 2021

I'll look into resolving this if you like.

@johanandren
Copy link
Member Author

Please do, thanks!

Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Build failures unrelated.

@seglo seglo merged commit 7b0932d into master Feb 1, 2021
@seglo seglo deleted the johanandren-patch-1 branch February 1, 2021 20:52
@conorgriffin
Copy link
Contributor

I think https://github.com/akka/alpakka/blob/master/ftp/src/test/scala/docs/scaladsl/SftpSpec.scala was committed by accident as part of this PR?

@seglo
Copy link
Member

seglo commented Feb 2, 2021

You're right. My mistake. I'll revert it tomorrow.

@seglo seglo mentioned this pull request Feb 2, 2021
@seglo seglo added this to the 3.0.0-M1 milestone Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants