Enforce withProperties Java API on passthrough messages #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debasishg
reviewed
Feb 3, 2021
| sealed trait JmsMessage extends JmsEnvelope[NotUsed] { | ||
|
|
||
| def withHeader(jmsHeader: JmsHeader): JmsMessage | ||
| sealed trait JmsEnvelopeWithProperties[+PassThrough] extends JmsEnvelope[PassThrough] { |
There was a problem hiding this comment.
Is this type parameter PassThrough used ? Or can we make it
sealed trait JmsEnvelopeWithProperties extends JmsEnvelope[NotUsed] {There was a problem hiding this comment.
I think it's required because it's used in pass through JMS messages. If I omit it then type param errors with the JmsMessage pass through factory methods.
debasishg
approved these changes
Feb 3, 2021
|
For the Lightbend customer that identified this issue you can try it out with this snapshot release version |
That was me, cheers; sorry for 4 month delay :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Java API
withProperties(properties: java.util.Map[String, Object])method was missing from several passthrough JMS message types. This PR adds a new trait to enforce its implementation.