Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Influxdb: emit instead of push in flow stage #2624

Merged
merged 1 commit into from
May 12, 2021

Conversation

mariohuizar
Copy link
Contributor

Fix for back-pressure within the Influxdb alpakka connector.
I had a problem with it, throwing the error:
Cannot push port (out(877880393)) twice, or before it being pulled
Did this small change and now works like a charm.
References #xxxx

@lightbend-cla-validator

Hi @marioJambit,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@seglo
Copy link
Member

seglo commented Mar 25, 2021

@marioJambit can you please sign the CLA?

@mariohuizar
Copy link
Contributor Author

@marioJambit can you please sign the CLA?

Done. Sorry I pushed with the wrong email address.

Copy link
Member

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a brief check I don't see why the port would not be available for a push, but I don't see an issue with using emit here either. LGTM.

@seglo seglo changed the title Influxdb: emit instead of push for improving back-pressure Influxdb: emit instead of push in flow stage May 12, 2021
@seglo seglo merged commit ef356f6 into akka:master May 12, 2021
@seglo seglo added this to the 3.0.0 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants