Google: Drop old jwt-core dependencies #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
dependency-change
|
I see. Hopefully that's a small subset of users who directly depend on the old |
seglo
changed the title
jwt-core dependencies
We can also help mitigate this via #2580. Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the
jwt-coredependency from the Google connectors since this is now handled ingoogle-common.Unfortunately, this is currently a potentially fatal bug: the
google-commonmodule depends on a recent version ofjwt-scalathat has a new Maven organization name but retains the same package name asjwt-core, which IIUC creates a classpath conflict that SBT will not automatically resolve via eviction. Due to API changes, if the oldJWTclasses are used instead of the new then authorization requests to Google will fail.