Fixed empty source XML parsing #2655 #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seetaramayya
commented
Apr 23, 2021
| case AsyncXMLStreamReader.EVENT_INCOMPLETE => | ||
| if (!isClosed(in)) pull(in) | ||
| else failStage(new IllegalStateException("Stream finished before event was fully parsed.")) | ||
| case AsyncXMLStreamReader.EVENT_INCOMPLETE if isClosed(in) && !started => completeStage() |
There was a problem hiding this comment.
In general, I like the checks on left hand side of => (actions on the right hand side of =>). If it is not good then I'll convert it to if elseif else
ennru
approved these changes
Apr 23, 2021
| case AsyncXMLStreamReader.EVENT_INCOMPLETE if isClosed(in) && !started => completeStage() | ||
| case AsyncXMLStreamReader.EVENT_INCOMPLETE if isClosed(in) => | ||
| failStage(new IllegalStateException("Stream finished before event was fully parsed.")) | ||
| case AsyncXMLStreamReader.EVENT_INCOMPLETE if !isClosed(in) => pull(in) |
There was a problem hiding this comment.
Suggested change
| case AsyncXMLStreamReader.EVENT_INCOMPLETE if !isClosed(in) => pull(in) | |
| case AsyncXMLStreamReader.EVENT_INCOMPLETE => pull(in) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit test to prove issue exists and afterwords fixed it