Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TarReaderStage only pull when needed, #2714 #2715

Merged
merged 1 commit into from Aug 10, 2021
Merged

Conversation

patriknw
Copy link
Member

  • to avoid pull twice bugs
  • maybe too defensive in some of the cases but since
    the handler switching and pulling from several places
    is rather difficult to follow it's better to be safe than sorry

Fixes #2714

* to avoid pull twice bugs
* maybe too defensive in some of the cases but since
  the handler switching and pulling from several places
  is rather difficult to follow it's better to be safe than sorry
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, the state switching makes it hard to follow.
LGTM.

@patriknw patriknw merged commit 768d8f4 into master Aug 10, 2021
@patriknw patriknw deleted the wip-2714-pull-patriknw branch August 10, 2021 07:50
@fernandoracca
Copy link

We have positive reports that this addresses an issue we've encountered of trying to pull data twice. 👍🏼

@patriknw
Copy link
Member Author

@fernandoracca Thanks for confirming. We have released 3.0.3, including this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TarReaderStage - Cannot pull port (flowIn) twice
3 participants