Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch: forward headers on bulk insert in SimpleFlowStage #2758

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

Charon11
Copy link
Contributor

Problem

enable to authenticate without login/password

Identification

headers not forward on onPush() method in ElasticsearchSimpleFlowStage

val request = HttpRequest(HttpMethods.POST)
.withUri(uri)
.withEntity(HttpEntity(NDJsonProtocol.`application/x-ndjson`, json))

Resolution

forward header from ElasticsearchConnectionSettings headers to HttpRequest header

@lightbend-cla-validator

Hi @Charon11,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@Charon11
Copy link
Contributor Author

Charon11 commented Oct 19, 2021

Lightbend Contributors License Agreement : 🆗 but still refuse

@ennru
Copy link
Member

ennru commented Nov 12, 2021

Your Lightbend CLA doesn't seem to be cleared, I checked manually. Did you sign it with the correct user Charon11?

@Charon11
Copy link
Contributor Author

Charon11 commented Dec 1, 2021

I submit it again

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 3.0.5 milestone Jan 3, 2022
@ennru ennru changed the title Elasticsearch: forward headers on bulk insert in ElasticsearchSimpleFlowStage Elasticsearch: forward headers on bulk insert in SimpleFlowStage Jan 3, 2022
@ennru ennru merged commit 878b996 into akka:master Jan 3, 2022
@ennru
Copy link
Member

ennru commented Jan 3, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants