google-common: Catch and return JWT errors #2788
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generateJwt
method (or rather, the underlying library) might throw an exception which is unhandled and makes the streams that require authentication fail without anything logged and any way to recover.This can be reproduced by simply changing the private key to something invalid, like adding a few extra characters, in this case a
java.security.InvalidKeyException
is thrown.This PR aims to catch the exception and return it in the
Future
so that the downstream can properly handle it.