Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-cloud-pub-sub-grpc: more imports in sample code #2873

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

raboof
Copy link
Member

@raboof raboof commented Jun 17, 2022

especially ByteString is useful to include explicitly, not to confuse
it with akka.util.ByteString

especially ByteString is useful to include explicitly, not to confuse
it with `akka.util.ByteString`
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 260cc3b into master Jun 27, 2022
@ennru ennru deleted the alpakka-google-pubsub-sample-imports branch June 27, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants