Resolve Akka.Remote host binding issue #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Apr 10, 2022
| @@ -30,7 +35,7 @@ private static AkkaConfigurationBuilder BuildRemoteHocon(this AkkaConfigurationB | |||
| /// <returns>The same <see cref="AkkaConfigurationBuilder"/> instance originally passed in.</returns> | |||
| public static AkkaConfigurationBuilder WithRemoting(this AkkaConfigurationBuilder builder, string hostname, int port, string publicHostname = null, int? publicPort = null) | |||
| { | |||
| var hoconBuilder = BuildRemoteHocon(builder, hostname, port); | |||
| var hoconBuilder = BuildRemoteHocon(builder, hostname, port, publicHostname, publicPort); | |||
There was a problem hiding this comment.
This was the fix - forgot to pass in the parameters to the BuildRemoteHocon method.
| @@ -8,6 +8,11 @@ public static class AkkaRemoteHostingExtensions | |||
| { | |||
| private static AkkaConfigurationBuilder BuildRemoteHocon(this AkkaConfigurationBuilder builder, string hostname, int port, string publicHostname = null, int? publicPort = null) | |||
| { | |||
| if (string.IsNullOrEmpty(publicHostname)) | |||
There was a problem hiding this comment.
Decided to resolve a potential papercut for most users here - have the system bind, by default, to a reachable socket and alias using the hostname if a publicHostname isn't explicitly specified. Means that most K8s / Docker scenarios should "just work" with these changes.
Aaronontheweb
added a commit
that referenced
this pull request
May 24, 2022
* Fixed tags (#14) * Ported over changes in the Petabridge.Library template (#15) * Upgrade to Akka.NET v1.4.35 (#16) Akka.Hosting was affected by akkadotnet/akka.net#5728 * Update RELEASE_NOTES.md (#17) * Bump Akka.Persistence.SqlServer from 1.4.32 to 1.4.35 (#18) Bumps [Akka.Persistence.SqlServer](https://github.com/akkadotnet/Akka.Persistence.SqlServer) from 1.4.32 to 1.4.35. - [Release notes](https://github.com/akkadotnet/Akka.Persistence.SqlServer/releases) - [Changelog](https://github.com/akkadotnet/Akka.Persistence.SqlServer/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/Akka.Persistence.SqlServer@1.4.32...1.4.35) --- updated-dependencies: - dependency-name: Akka.Persistence.SqlServer dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * removed `ClusterShardingSettings` from sharding extensions (#20) * Bump docfx.console from 2.59.0 to 2.59.1 (#19) Bumps [docfx.console](https://github.com/dotnet/docfx) from 2.59.0 to 2.59.1. - [Release notes](https://github.com/dotnet/docfx/releases) - [Changelog](https://github.com/dotnet/docfx/blob/dev/RELEASENOTE.md) - [Commits](dotnet/docfx@v2.59.0...v2.59.1) --- updated-dependencies: - dependency-name: docfx.console dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * added `ShardRegionProxy` support to cluster hosting * added `DistributedPubSub` support * added v0.1.3 release notes * Added `WithCustomSerializer` builder method (#22) * added support for registering custom serializers to `ActorSystem` * added v0.1.4 Release Notes * Bump FluentAssertions from 6.5.1 to 6.6.0 (#24) Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.5.1 to 6.6.0. - [Release notes](https://github.com/fluentassertions/fluentassertions/releases) - [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1) - [Commits](fluentassertions/fluentassertions@6.5.1...6.6.0) --- updated-dependencies: - dependency-name: FluentAssertions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump AkkaVersion from 1.4.35 to 1.4.36 (#27) Bumps `AkkaVersion` from 1.4.35 to 1.4.36. Updates `Akka.DependencyInjection` from 1.4.35 to 1.4.36 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.35...1.4.36) Updates `Akka.Remote` from 1.4.35 to 1.4.36 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.35...1.4.36) Updates `Akka.Cluster.Sharding` from 1.4.35 to 1.4.36 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.35...1.4.36) Updates `Akka.Persistence.Query.Sql` from 1.4.35 to 1.4.36 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.35...1.4.36) --- updated-dependencies: - dependency-name: Akka.DependencyInjection dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Remote dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Cluster.Sharding dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Persistence.Query.Sql dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cleanup WithSqlServerPersistence style (#26) * add Akka.Persistence.PostgreSql.Hosting support (#28) * Added v0.1.5 Release Notes (#29) ## [0.1.5] / 06 April 2022 - Added `Akka.Persistence.PostgreSql.Hosting` NuGet package to support Postgres users. * added DI sanity check specs (#31) * Fixed issues with duplicate `IServiceProvider` registration (#32) * commits * fixed DI registration * fixed all remaining DI and instantiation issues * clean up * added Akka.Hosting v0.2.0 release notes (#34) * added v0.2.1 release notes (#35) * Resolve Akka.Remote host binding issue (#37) * adding Akka.Remote.Hosting specs * resolved issue * Added 0.2.2 release notes (#38) ## [0.2.2] / 10 April 2022 - [Bugfix: Akka.Remote.Hosting doesn't support `public-hostname` correctly](#36) * Bump docfx.console from 2.59.1 to 2.59.2 (#39) Bumps [docfx.console](https://github.com/dotnet/docfx) from 2.59.1 to 2.59.2. - [Release notes](https://github.com/dotnet/docfx/releases) - [Changelog](https://github.com/dotnet/docfx/blob/dev/RELEASENOTE.md) - [Commits](dotnet/docfx@v2.59.1...v2.59.2) --- updated-dependencies: - dependency-name: docfx.console dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Added link to explainer video * Update README.md * Bump AkkaVersion from 1.4.36 to 1.4.37 (#41) Bumps `AkkaVersion` from 1.4.36 to 1.4.37. Updates `Akka.DependencyInjection` from 1.4.36 to 1.4.37 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.36...1.4.37) Updates `Akka.Remote` from 1.4.36 to 1.4.37 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.36...1.4.37) Updates `Akka.Cluster.Sharding` from 1.4.36 to 1.4.37 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.36...1.4.37) Updates `Akka.Persistence.Query.Sql` from 1.4.36 to 1.4.37 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/dev/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.36...1.4.37) --- updated-dependencies: - dependency-name: Akka.DependencyInjection dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Remote dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Cluster.Sharding dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Persistence.Query.Sql dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add interfaces for the ActorRegistry to allow mocking in tests (#42) * Add interfaces to allow the ActorRegistry to be used in unit tests. * Add interfaces to allow the ActorRegistry to be used in unit tests. * Make sure everything compiles again after upstream changes. * Ensure the IActorRegistry and IReadOnlyActorRegistry are registered with DI. Co-authored-by: Aaron Stannard <aaron@petabridge.com> * Bump FluentAssertions from 6.6.0 to 6.7.0 (#47) Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.6.0 to 6.7.0. - [Release notes](https://github.com/fluentassertions/fluentassertions/releases) - [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1) - [Commits](fluentassertions/fluentassertions@6.6.0...6.7.0) --- updated-dependencies: - dependency-name: FluentAssertions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump AkkaVersion from 1.4.37 to 1.4.38 (#45) Bumps `AkkaVersion` from 1.4.37 to 1.4.38. Updates `Akka.DependencyInjection` from 1.4.37 to 1.4.38 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/1.4.38/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.37...1.4.38) Updates `Akka.Remote` from 1.4.37 to 1.4.38 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/1.4.38/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.37...1.4.38) Updates `Akka.Cluster.Sharding` from 1.4.37 to 1.4.38 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/1.4.38/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.37...1.4.38) Updates `Akka.Persistence.Query.Sql` from 1.4.37 to 1.4.38 - [Release notes](https://github.com/akkadotnet/akka.net/releases) - [Changelog](https://github.com/akkadotnet/akka.net/blob/1.4.38/RELEASE_NOTES.md) - [Commits](akkadotnet/akka.net@1.4.37...1.4.38) --- updated-dependencies: - dependency-name: Akka.DependencyInjection dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Remote dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Cluster.Sharding dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Akka.Persistence.Query.Sql dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump Microsoft.NET.Test.Sdk from 17.1.0 to 17.2.0 (#46) Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.1.0 to 17.2.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.1.0...v17.2.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * close #48 - fixed source of NRE upon shutdown (#49) * close #48 - fixed source of NRE upon shutdown * added NRE check in `StopAsync` * added throw-able `ActorRegistry.Register` method (#50) * added throw-able `ActorRegistry.Register` method * Addressed comments * added null `IActorRef` checks * adding `ClusterSingleton` hosting methods (#51) * adding `ClusterSingleton` hosting methods * fixed compilation errors * added test output logger * fixed package metadata issue * fixed bug with singleton proxy startup * made tests more configurable * working on fixing specs * fixed ClusterSingletonProxy configuration * fixed bug with singleton and proxy method * Update AkkaClusterHostingExtensions.cs * fixed NuGet icon and packaging metadata (#52) * added 0.3.0 release notes (#53) Co-authored-by: Ebere Abanonu <eaba@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Cumps <david@cumps.be> Co-authored-by: Sean Farrow <SeanFarrow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
Changes
Added a reproduction spec for #36 and am currently working on a fix for it.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):