Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid client instantiation for Azure Lease #1063

Merged
merged 2 commits into from Dec 1, 2022
Merged

Fix invalid client instantiation for Azure Lease #1063

merged 2 commits into from Dec 1, 2022

Conversation

Arkatufus
Copy link
Contributor

Fixes #1027

The code should instantiate BlobServiceClient using the TokenProvider, not BlobContainerClient, instantiating BlobContainerClient requires the container name to be embedded inside the service URI.

Changes

  • Change BlobContainerClient to BlobServiceClient

@Aaronontheweb Aaronontheweb added leases Akka.Coordination lease implementations azure labels Dec 1, 2022
@Aaronontheweb Aaronontheweb enabled auto-merge (squash) December 1, 2022 17:22
Aaronontheweb
Aaronontheweb approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit fc00feb into akkadotnet:dev Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
azure leases Akka.Coordination lease implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Akka.Coordination.Azure is not able to retrieve leases
2 participants
@Arkatufus @Aaronontheweb