Drop the janky scala routing and use Ceen built in routing instead #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Dec 29, 2022
| @@ -41,14 +41,14 @@ public ClusterMember(Address node, long nodeUid, MemberStatus status, ImmutableH | |||
|
|
|||
| public sealed class SeedNodes | |||
| { | |||
| public SeedNodes(Address selfNode, ImmutableHashSet<ClusterMember> nodes) | |||
| public SeedNodes(Address selfNode, ImmutableList<ClusterMember> nodes) | |||
There was a problem hiding this comment.
Is it possible that this could allow duplicates?
There was a problem hiding this comment.
Nope, it can't - comes from the Cluster object itself which already de-dupes them.
| @@ -48,21 +54,31 @@ public static class AkkaHostingExtensions | |||
| /// </returns> | |||
| public static AkkaConfigurationBuilder WithAkkaManagement( | |||
| this AkkaConfigurationBuilder builder, | |||
| Dictionary<string, IManagementRouteProvider>? providers = null, | |||
There was a problem hiding this comment.
Move this to the back of the parameter list, since it's an advanced feature
There was a problem hiding this comment.
I'd make Akka.Cluster.Bootstrap the default here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.