Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coordination.Kubernetes] Change hosting extension to use options instead of setup #1172

Merged
merged 1 commit into from Jan 5, 2023
Merged

[Coordination.Kubernetes] Change hosting extension to use options instead of setup #1172

merged 1 commit into from Jan 5, 2023

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Hosting extension accepts KubernetesLeaseOption instead of KubernetesLeaseSetup
  • Settings are applied via injected HOCON settings instead of being injected via setup
  • Add a more comprehensive setting unit tests
  • Hocon settings fixes

Aaronontheweb
Aaronontheweb approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) January 3, 2023 23:32
@Aaronontheweb Aaronontheweb merged commit e59bdab into akkadotnet:dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb