Add programmatic credential provider for the EC2 client #14
Conversation
src/discovery/Akka.Discovery.AwsApi/Ec2/Ec2ConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
src/discovery/Akka.Discovery.AwsApi/Ec2/Ec2ConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
| public override AWSCredentials ClientCredentials { get; } = new AnonymousAWSCredentials(); | ||
| } | ||
|
|
||
| public sealed class Ec2InstanceMetadataCredentialProvider : Ec2CredentialProvider |
There was a problem hiding this comment.
Any reason this shouldn't be the default? Anonymous will almost always fail for these calls.
There was a problem hiding this comment.
good point, i'll change that
There was a problem hiding this comment.
Might want to rename the class too (i.e. change it to anonymous something something), just to clear it up, and add an XML-DOC comment indicating that the instance metadata is the default. Then we should be good to go.
There was a problem hiding this comment.
Changed the name of the class from "Default" to "Anonymous" to avoid confusion
| public abstract AWSCredentials ClientCredentials { get; } | ||
| } | ||
|
|
||
| public sealed class AnonymousEc2CredentialProvider : Ec2CredentialProvider |
| { | ||
| if (!EC2InstanceMetadata.IsIMDSEnabled) | ||
| { | ||
| _log.Warning("Could not obtain EC2 client credentials because instance metadata is disabled. Using anonymous credentials instead."); |
| #### Ec2InstanceMetadataCredentialProvider | ||
| `Ec2InstanceMetadataCredentialProvider` will try its best to retrieve the correct session | ||
| credential provider using the AWS EC2 instance metadata API. It will return an `AnonymousAWSCredential` | ||
| if it fails to obtain a credential from the metadata API service. |
There was a problem hiding this comment.
We should probably add a link back to the relevant AWS documentation here though
There was a problem hiding this comment.
Its on the bottom of the readme
No description provided.