Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management should not use IPAddress.Any as its default hostname #156

Merged
merged 3 commits into from Oct 1, 2021
Merged

Management should not use IPAddress.Any as its default hostname #156

merged 3 commits into from Oct 1, 2021

Conversation

Arkatufus
Copy link
Contributor

Change the way Akka.Management define default hostname.

  • If not overriden or empty, check akka.remote.dot-netty.tcp.public-hostname, reason being that this is the settings being overriden by Akka.DockerBootstrap
  • If akka.remote.dot-netty.tcp.public-hostname is empty, we use Dns.GetHostName instead.

@Aaronontheweb Aaronontheweb merged commit 8abde68 into akkadotnet:dev Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb