Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Akka.Discovery.Config.Hosting #1758

Merged
merged 4 commits into from May 19, 2023
Merged

Add Akka.Discovery.Config.Hosting #1758

merged 4 commits into from May 19, 2023

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Add Akka.Management missing AkkaManagementOptions feature
  • Add AkkaManagementOptions unit tests
  • Add Akka.Discovery.Config.Hosting
  • Add Akka.Discovery.Config.Hosting.Tests
    • Settings tests
    • End-to-end test

Aaronontheweb
Aaronontheweb requested changes May 19, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collapse the DLLs and then add some docs to the README.md on how to use these settings, but otherwise LGTM

src/discovery/config/Akka.Discovery.Config.Hosting/Akka.Discovery.Config.Hosting.csproj Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fold this into the Akka.Management base project - one less NuGet package for users to worry about.

src/management/Akka.Management/AkkaHostingExtensions.cs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus
Copy link
Contributor Author

Done

@Aaronontheweb Aaronontheweb merged commit 2bf82db into akkadotnet:dev May 19, 2023
3 checks passed
@Arkatufus Arkatufus mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb