Fix Target throws an NRE when querying port name on container with IP and no ports #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
requested changes
Oct 28, 2021
| new V1Pod( | ||
| spec: new V1PodSpec(new List<V1Container> | ||
| { | ||
| new V1Container("akka-cluster-tooling-example", ports:new List<V1ContainerPort> |
There was a problem hiding this comment.
Add a second container to this list that doesn't have any ports exposed and that should do it
Arkatufus
commented
Oct 28, 2021
| new V1Pod( | ||
| spec: new V1PodSpec(new List<V1Container> | ||
| { | ||
| new V1Container("akka-cluster-tooling-example") |
There was a problem hiding this comment.
You mean this one?
There was a problem hiding this comment.
A pod can have multiple containers - that's the edge case that triggered the error in this case.
…ub.com:Arkatufus/Akka.Management into #223_DISCOVERY_KubernetesApi_NRE_during_lookup
|
@Arkatufus looks like one of the tests in the suite is racy - binding on the same port concurrently with another test. |
|
I'll give it another look |
Aaronontheweb
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223