Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Discovery.Azure #723

Merged
merged 2 commits into from Aug 2, 2022
Merged

Fixes for Discovery.Azure #723

merged 2 commits into from Aug 2, 2022

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Update the OData query, missing "L" qualifier to mark that the numbers are to be read as an Int64, Azure would default to reading any numbers as an Int32 and throws an overflow parse error.
  • Fix discovery Lookup method, it should not throw when the Ask operation timed out.

Aaronontheweb
Aaronontheweb approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 5948fba into akkadotnet:dev Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
akka-discovery azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb