Replace Dns.GetHostEntry, it might not return the original IP address #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
changed the title
Aaronontheweb
approved these changes
Aug 8, 2022
| !Equals(i, IPAddress.IPv6Loopback)); | ||
| if (IPAddress.TryParse(_settings.HostName, out _address)) | ||
| { | ||
| if (_address.Equals(IPAddress.Any) || _address.Equals(IPAddress.IPv6Any)) |
| else | ||
| { | ||
| _host = _settings.HostName; | ||
| _address = Dns.GetHostAddresses(_host) |
There was a problem hiding this comment.
We need to add a test for when:
- Hostname is valid for routing (externally)
- Hostname is not assigned to anything locally via DHCP
This is an extremely common scenario in cloud environments outside of K8s since much of the network address translation happens at the software level above the VM. It's why we have the public-hostname and public-port settings in Akka.Remote.
I would not worry about this right now though - save it for integration testing with Azure App Service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms, having the exact IP address is crucial (eg. in Azure App Services), need to preserve the original IP address being passed into the settings.