Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discovery.AwsApi] Add Akka.Hosting extension methods #818

Merged
merged 4 commits into from Sep 8, 2022
Merged

[Discovery.AwsApi] Add Akka.Hosting extension methods #818

merged 4 commits into from Sep 8, 2022

Conversation

Arkatufus
Copy link
Contributor

Changes

  • Add Akka.Hosting extension methods to Akka.Discovery.AwsApi.Ec2
  • Change EcsDiscovery class name to AwsEcsDiscovery to make it consistent with the Ec2 counterpart
  • Add Akka.Hosting extension methods to Akka.Discovery.AwsApi.Ecs
  • Fix the AWS ECS sample Dockerfile
  • Update the AWS ECS sample project to use the Akka.Hosting extension methods.

@Aaronontheweb
Copy link
Member

@Arkatufus looks like your unit tests are failing here

Aaronontheweb
Aaronontheweb approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) September 8, 2022 19:02
@Aaronontheweb Aaronontheweb merged commit 1f6f12d into akkadotnet:dev Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Arkatufus @Aaronontheweb