Change default journal read and write mode to tag table #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arkatufus
commented
Feb 3, 2023
•
Arkatufus
commented
- Change default journal read and write mode
- Fix DAO logic for tag table
to11mtm
reviewed
Feb 7, 2023
| await using var tx = await db.BeginTransactionAsync(IsolationLevel.ReadCommitted); | ||
| try | ||
| { | ||
| await ConsumeSequenceForTagInsert(xs, db); |
There was a problem hiding this comment.
So, the purpose of ConsumeSequenceForTagInsert was as follows:
Because we are batching all of our writes, but bulk copy is -much- faster than row-by-row, the idea was that in cases of:
ItemWithTags ItemWithTags ItemNoTags ItemNoTags ItemNoTags ItemNoTags ItemWithTags ItemNoTags etc... we would still be able to take advantage of bulk-copy for the no-tag cases, and at least lessen the write throughput penalty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.