Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Persistence.Query Hosting extension support. #283

Merged
merged 1 commit into from Jul 20, 2023

Conversation

Arkatufus
Copy link
Contributor

Changes

Fix erroneous generated Persistence.Query hocon by Akka.Persistence.Sql.Hosting

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -302,7 +302,7 @@ public static class HostingExtensions
builder
.AddHocon(journalOptions.ToConfig(), HoconAddMode.Prepend)
.AddHocon(journalOptions.DefaultConfig, HoconAddMode.Append)
.AddHocon(SqlPersistence.DefaultConfiguration, HoconAddMode.Append),
.AddHocon(journalOptions.DefaultQueryConfig, HoconAddMode.Append),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@Aaronontheweb Aaronontheweb merged commit 28492ea into akkadotnet:dev Jul 20, 2023
1 of 3 checks passed
@Arkatufus Arkatufus deleted the Fix_hosting_journal_query branch July 20, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants