-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Akka to 1.5.1 #281
Conversation
@@ -65,7 +65,17 @@ public QuartzActor(IScheduler scheduler) | |||
|
|||
protected override bool Receive(object message) | |||
{ | |||
return message.Match().With<CreateJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled; | |||
switch (message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it into switch @Arkatufus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -38,7 +38,17 @@ protected override void OnSchedulerCreated(IScheduler scheduler) | |||
|
|||
protected override bool Receive(object message) | |||
{ | |||
return message.Match().With<CreatePersistentJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled; | |||
switch (message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it into switch @Arkatufus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<VersionPrefix>1.4.19</VersionPrefix> | ||
<PackageReleaseNotes>Updated Akka to 1.4.19 | ||
upgraded to Quartz.NET 3.3.2</PackageReleaseNotes> | ||
<VersionPrefix>1.5.1</VersionPrefix> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Akka.NET to 1.5.1
<AkkaVersion>1.4.49</AkkaVersion> | ||
<QuartzVersion>3.6.0</QuartzVersion> | ||
<AkkaVersion>1.5.1</AkkaVersion> | ||
<QuartzVersion>3.6.2</QuartzVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Quartz.NET to 3.6.2
<XunitVersion>2.4.2</XunitVersion> | ||
<XunitRunnerVersion>2.4.5</XunitRunnerVersion> | ||
<TestSdkVersion>17.4.1</TestSdkVersion> | ||
<TestSdkVersion>17.5.0</TestSdkVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Microsoft.NET.Test.Sdk
to 17.5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated Akka.NET to 1.5.1 @Arkatufus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -65,7 +65,17 @@ public QuartzActor(IScheduler scheduler) | |||
|
|||
protected override bool Receive(object message) | |||
{ | |||
return message.Match().With<CreateJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled; | |||
switch (message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -38,7 +38,17 @@ protected override void OnSchedulerCreated(IScheduler scheduler) | |||
|
|||
protected override bool Receive(object message) | |||
{ | |||
return message.Match().With<CreatePersistentJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled; | |||
switch (message) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Akka.NET
to 1..5.1Quartz.NET
to 3.6.2Microsoft.NET.Test.Sdk
to 17.5.0Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):