Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Akka to 1.5.1 #281

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Updated Akka to 1.5.1 #281

merged 1 commit into from
Mar 27, 2023

Conversation

eaba
Copy link
Contributor

@eaba eaba commented Mar 27, 2023

Changes

  • Update Akka.NET to 1..5.1
  • Update Quartz.NET to 3.6.2
  • Update Microsoft.NET.Test.Sdk to 17.5.0

Checklist

For significant changes, please ensure that the following have been completed (delete if not relevant):

@@ -65,7 +65,17 @@ public QuartzActor(IScheduler scheduler)

protected override bool Receive(object message)
{
return message.Match().With<CreateJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled;
switch (message)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it into switch @Arkatufus

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -38,7 +38,17 @@ protected override void OnSchedulerCreated(IScheduler scheduler)

protected override bool Receive(object message)
{
return message.Match().With<CreatePersistentJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled;
switch (message)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it into switch @Arkatufus

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<VersionPrefix>1.4.19</VersionPrefix>
<PackageReleaseNotes>Updated Akka to 1.4.19
upgraded to Quartz.NET 3.3.2</PackageReleaseNotes>
<VersionPrefix>1.5.1</VersionPrefix>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Akka.NET to 1.5.1

<AkkaVersion>1.4.49</AkkaVersion>
<QuartzVersion>3.6.0</QuartzVersion>
<AkkaVersion>1.5.1</AkkaVersion>
<QuartzVersion>3.6.2</QuartzVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Quartz.NET to 3.6.2

<XunitVersion>2.4.2</XunitVersion>
<XunitRunnerVersion>2.4.5</XunitRunnerVersion>
<TestSdkVersion>17.4.1</TestSdkVersion>
<TestSdkVersion>17.5.0</TestSdkVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Microsoft.NET.Test.Sdk to 17.5.0

Copy link
Contributor Author

@eaba eaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated Akka.NET to 1.5.1 @Arkatufus

@eaba eaba marked this pull request as ready for review March 27, 2023 17:20
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -65,7 +65,17 @@ public QuartzActor(IScheduler scheduler)

protected override bool Receive(object message)
{
return message.Match().With<CreateJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled;
switch (message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -38,7 +38,17 @@ protected override void OnSchedulerCreated(IScheduler scheduler)

protected override bool Receive(object message)
{
return message.Match().With<CreatePersistentJob>(CreateJobCommand).With<RemoveJob>(RemoveJobCommand).WasHandled;
switch (message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 9f62f5e into akkadotnet:dev Mar 27, 2023
@eaba eaba deleted the akka.net_1.5.1 branch March 28, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants