Handle edge case for dictionary lookup. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to11mtm
commented
Feb 12, 2024
| //Otherwise, we check whether we are there | ||
| // (if a competitor added it on resize, we see via fence) | ||
| // and if not, add ours. | ||
| if (_formatters.Length <= i) | ||
| while (_formatters.Length <= i) |
There was a problem hiding this comment.
This is an edge case, so I think it's OK to have the pain of multiple realloc and copies for now, we can create separate issue to resolve if desired. It should only come up if something along the lines of multiple actorsystems start and deserialize in the wrong order.
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Handles an edge case in Int Lookup dictionary for multiple actorsystems that may receive types in largely different orders.