Add AMQP retry mechanism and example projects #312
Conversation
| } | ||
|
|
||
| retry--; | ||
| if (retry == 0) |
| @@ -51,10 +69,45 @@ public override void PreStart() | |||
| { | |||
| base.PreStart(); | |||
|
|
|||
| var consumerCallback = GetAsyncCallback<Message>(HandleDelivery); | |||
| _receiver.Start(_amqpSourceSettings.Credit, (_, m) => consumerCallback.Invoke(m)); | |||
| Connect().Wait(); | |||
There was a problem hiding this comment.
Connect call is blocking here but there isn't much you can do about that - have to wait for the execution to finish somewhere in order to start the message pump.
There was a problem hiding this comment.
Actually, come to think of it - might want to just have the async state machine invoke a callback on the stage and signal failure / success. Given that this retry + backoff mechanism can run for several minutes, you don't want to tie the process up for that long. How hard would it be to do that?
There was a problem hiding this comment.
I'll give it a look see, it shouldn't be that hard
There was a problem hiding this comment.
On second thought, can we separate this into a different PR?
It "works" as it is, I'll work on the thread blocking issue on another PR.
| public override void PreStart() | ||
| { | ||
| base.PreStart(); | ||
|
|
||
| Connect().Wait(); |
There was a problem hiding this comment.
Same comment as below about blocking on a really long-running call
Closes #288
Adds settings variant that's able to manage the
ConnectionandSessionstates so that it plays nice with disconnection/reconnection; all the user need to do is provide theAddressobject.