Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully qualified type name with assembly cant be used as property name #79

Closed
Zetanova opened this issue Mar 7, 2019 · 1 comment
Closed

Comments

@Zetanova
Copy link

Zetanova commented Mar 7, 2019

akka.net is using for some sections like event-adapter and serializer
"fully qualified type name with assembly" as property names.
Type names includes invalid tokens/characters (like dot and comma) for the property name .

Example:

akka {
persistence {
        journal {
          plugin = "akka.persistence.journal.sql-server"
          sql-server {
            class = "Akka.Persistence.SqlServer.Journal.BatchingSqlServerJournal, Akka.Persistence.SqlServer"
            schema-name = dbo
            table-name = EventJournal
            auto-initialize = off
            event-adapters {
              json-adapter = "Demo.EventAdapter, Demo"
            }
            event-adapter-bindings {
              "Demo.IMyEvent" = json-adapter #this line makes a invalid token exception
            }
          }
        } 
}
}
Arkatufus added a commit to Arkatufus/HOCON that referenced this issue Apr 2, 2019
@Arkatufus
Copy link
Contributor

Arkatufus commented Apr 2, 2019

The exception should not happen in the standalone HOCON library, waiting for the main Akka.Net library to adopt the new HOCON library.
https://github.com/Arkatufus/HOCON/blob/79_Add_test_for_quoted_key/src/Hocon.Tests/PathTests.cs#L55

Aaronontheweb pushed a commit that referenced this issue Apr 3, 2019
* Add specific test for #79

* Add comma case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants