Skip to content

Commit

Permalink
#3786 - removed two Cluster must cancel join prematurely specs (#3803)
Browse files Browse the repository at this point in the history
  • Loading branch information
Aaronontheweb committed May 22, 2019
1 parent c11f5b7 commit 0ddfa3c
Showing 1 changed file with 0 additions and 51 deletions.
51 changes: 0 additions & 51 deletions src/core/Akka.Cluster.Tests/ClusterSpec.cs
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ public void A_cluster_must_send_current_cluster_state_to_one_receiver_when_reque
ExpectMsg<ClusterEvent.CurrentClusterState>();
}

// this should be the last test step, since the cluster is shutdown
[Fact]
public void A_cluster_must_publish_member_removed_when_shutdown()
{
Expand Down Expand Up @@ -199,11 +198,6 @@ public void A_cluster_must_complete_LeaveAsync_task_upon_being_removed()
Cluster.Get(sys2).LeaveAsync().IsCompleted.Should().BeTrue();
}

//#if CORECLR
// [Fact(Skip = "Fails on .NET Core")]
//#else
// [Fact(Skip = "Fails flakily on .NET 4.5")]
//#endif
[Fact]
public void A_cluster_must_return_completed_LeaveAsync_task_if_member_already_removed()
{
Expand Down Expand Up @@ -339,29 +333,6 @@ public void A_cluster_must_be_able_to_JoinAsync()
}).Wait(timeout);
}

[Fact]
public void A_cluster_must_be_able_to_prematurelly_cancel_JoinAsync()
{
var timeout = TimeSpan.FromSeconds(10);

try
{
var cancel = new CancellationTokenSource();
cancel.Cancel(true);
var task = _cluster.JoinAsync(_selfAddress, cancel.Token);

Assert.Throws<AggregateException>(() => task.Wait(timeout))
.Flatten()
.InnerException.Should().BeOfType<TaskCanceledException>();

task.IsCanceled.Should().BeTrue();
}
finally
{
_cluster.Shutdown();
}
}

[Fact]
public void A_cluster_JoinAsync_must_fail_if_could_not_connect_to_cluster()
{
Expand Down Expand Up @@ -442,28 +413,6 @@ public void A_cluster_JoinSeedNodesAsync_must_fail_if_could_not_connect_to_clust
}
}

[Fact]
public void A_cluster_must_be_able_to_prematurelly_cancel_join_async_seed_nodes()
{
var timeout = TimeSpan.FromSeconds(10);

try
{
var cancel = new CancellationToken(true);
var task = _cluster.JoinSeedNodesAsync(new[] { _selfAddress }, cancel);

Assert.Throws<AggregateException>(() => task.Wait(timeout))
.Flatten()
.InnerException.Should().BeOfType<TaskCanceledException>();

task.IsCanceled.Should().BeTrue();
}
finally
{
_cluster.Shutdown();
}
}

[Fact]
public void A_cluster_must_allow_to_resolve_RemotePathOf_any_actor()
{
Expand Down

0 comments on commit 0ddfa3c

Please sign in to comment.