Skip to content

Commit

Permalink
Remove obsolete methods from Akka.IO (#6456)
Browse files Browse the repository at this point in the history 
* Remove obsolete methods from Akka.IO

* Update API Verify list
  • Loading branch information
@Arkatufus
Arkatufus committed Feb 27, 2023
1 parent 026f737 commit 3ec5ea0
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 82 deletions.
12 changes: 0 additions & 12 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Core.verified.txt
View file
Expand Up @@ -3486,9 +3486,6 @@ namespace Akka.IO
public class DatagramChannelCreator : Akka.IO.Inet.SocketOption
{
public DatagramChannelCreator() { }
[System.ObsoleteAttribute("Please use the method with AddressFamily parameter. Using this method will always" +
" return an IPv6 bound UDP endpoint.")]
public virtual System.Net.Sockets.Socket Create() { }
public virtual System.Net.Sockets.Socket Create(System.Net.Sockets.AddressFamily addressFamily) { }
}
public class static SO
Expand Down Expand Up @@ -3881,9 +3878,6 @@ namespace Akka.IO
}
public sealed class Send : Akka.IO.Udp.Command
{
[System.ObsoleteAttribute("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(Byt" +
"eString, EndPoint, Event)` instead.")]
public Send(System.Collections.Generic.IEnumerator<System.ArraySegment<byte>> payload, System.Net.EndPoint target, Akka.IO.Udp.Event ack) { }
public Send(Akka.IO.ByteString payload, System.Net.EndPoint target, Akka.IO.Udp.Event ack) { }
public Akka.IO.Udp.Event Ack { get; }
public Akka.IO.ByteString Payload { get; }
Expand Down Expand Up @@ -3975,9 +3969,6 @@ namespace Akka.IO
}
public sealed class Send : Akka.IO.UdpConnected.Command
{
[System.ObsoleteAttribute("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(Byt" +
"eString, EndPoint, Event)` instead.")]
public Send(System.Collections.Generic.IEnumerator<System.ArraySegment<byte>> payload, Akka.IO.UdpConnected.Event ack) { }
public Send(Akka.IO.ByteString payload, object ack) { }
public object Ack { get; }
public Akka.IO.ByteString Payload { get; }
Expand Down Expand Up @@ -4007,9 +3998,6 @@ namespace Akka.IO
}
public class UdpSettings
{
[System.ObsoleteAttribute("Please the constructor without directBufferSize and maxDirectBufferPoolSize param" +
"eter")]
public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int directBufferSize, int maxDirectBufferPoolSize, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher) { }
public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher) { }
public int BatchReceiveLimit { get; }
public string BufferPoolConfigPath { get; }
Expand Down
12 changes: 0 additions & 12 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.DotNet.verified.txt
View file
Expand Up @@ -3493,9 +3493,6 @@ namespace Akka.IO
public class DatagramChannelCreator : Akka.IO.Inet.SocketOption
{
public DatagramChannelCreator() { }
[System.ObsoleteAttribute("Please use the method with AddressFamily parameter. Using this method will always" +
" return an IPv6 bound UDP endpoint.")]
public virtual System.Net.Sockets.Socket Create() { }
public virtual System.Net.Sockets.Socket Create(System.Net.Sockets.AddressFamily addressFamily) { }
}
public class static SO
Expand Down Expand Up @@ -3888,9 +3885,6 @@ namespace Akka.IO
}
public sealed class Send : Akka.IO.Udp.Command
{
[System.ObsoleteAttribute("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(Byt" +
"eString, EndPoint, Event)` instead.")]
public Send(System.Collections.Generic.IEnumerator<System.ArraySegment<byte>> payload, System.Net.EndPoint target, Akka.IO.Udp.Event ack) { }
public Send(Akka.IO.ByteString payload, System.Net.EndPoint target, Akka.IO.Udp.Event ack) { }
public Akka.IO.Udp.Event Ack { get; }
public Akka.IO.ByteString Payload { get; }
Expand Down Expand Up @@ -3982,9 +3976,6 @@ namespace Akka.IO
}
public sealed class Send : Akka.IO.UdpConnected.Command
{
[System.ObsoleteAttribute("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(Byt" +
"eString, EndPoint, Event)` instead.")]
public Send(System.Collections.Generic.IEnumerator<System.ArraySegment<byte>> payload, Akka.IO.UdpConnected.Event ack) { }
public Send(Akka.IO.ByteString payload, object ack) { }
public object Ack { get; }
public Akka.IO.ByteString Payload { get; }
Expand Down Expand Up @@ -4014,9 +4005,6 @@ namespace Akka.IO
}
public class UdpSettings
{
[System.ObsoleteAttribute("Please the constructor without directBufferSize and maxDirectBufferPoolSize param" +
"eter")]
public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int directBufferSize, int maxDirectBufferPoolSize, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher) { }
public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher) { }
public int BatchReceiveLimit { get; }
public string BufferPoolConfigPath { get; }
Expand Down
12 changes: 0 additions & 12 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveCore.Net.verified.txt
View file
Expand Up @@ -3486,9 +3486,6 @@ namespace Akka.IO
public class DatagramChannelCreator : Akka.IO.Inet.SocketOption
{
public DatagramChannelCreator() { }
[System.ObsoleteAttribute("Please use the method with AddressFamily parameter. Using this method will always" +
" return an IPv6 bound UDP endpoint.")]
public virtual System.Net.Sockets.Socket Create() { }
public virtual System.Net.Sockets.Socket Create(System.Net.Sockets.AddressFamily addressFamily) { }
}
public class static SO
Expand Down Expand Up @@ -3881,9 +3878,6 @@ namespace Akka.IO
}
public sealed class Send : Akka.IO.Udp.Command
{
[System.ObsoleteAttribute("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(Byt" +
"eString, EndPoint, Event)` instead.")]
public Send(System.Collections.Generic.IEnumerator<System.ArraySegment<byte>> payload, System.Net.EndPoint target, Akka.IO.Udp.Event ack) { }
public Send(Akka.IO.ByteString payload, System.Net.EndPoint target, Akka.IO.Udp.Event ack) { }
public Akka.IO.Udp.Event Ack { get; }
public Akka.IO.ByteString Payload { get; }
Expand Down Expand Up @@ -3975,9 +3969,6 @@ namespace Akka.IO
}
public sealed class Send : Akka.IO.UdpConnected.Command
{
[System.ObsoleteAttribute("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(Byt" +
"eString, EndPoint, Event)` instead.")]
public Send(System.Collections.Generic.IEnumerator<System.ArraySegment<byte>> payload, Akka.IO.UdpConnected.Event ack) { }
public Send(Akka.IO.ByteString payload, object ack) { }
public object Ack { get; }
public Akka.IO.ByteString Payload { get; }
Expand Down Expand Up @@ -4007,9 +3998,6 @@ namespace Akka.IO
}
public class UdpSettings
{
[System.ObsoleteAttribute("Please the constructor without directBufferSize and maxDirectBufferPoolSize param" +
"eter")]
public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int directBufferSize, int maxDirectBufferPoolSize, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher) { }
public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher) { }
public int BatchReceiveLimit { get; }
public string BufferPoolConfigPath { get; }
Expand Down
7 changes: 0 additions & 7 deletions src/core/Akka.Tests/IO/UdpIntegrationSpec.cs
View file
Expand Up @@ -345,13 +345,6 @@ class AssertOpenDatagramChannel : Inet.DatagramChannelCreator
{
public int OpenCalled { get; set; }


public override Socket Create()
{
OpenCalled += 1;
return base.Create();
}

public override Socket Create(AddressFamily addressFamily)
{
OpenCalled += 1;
Expand Down
6 changes: 0 additions & 6 deletions src/core/Akka/IO/Inet.cs
View file
Expand Up @@ -76,12 +76,6 @@ public abstract class AbstractSocketOptionV2 : SocketOptionV2 { }
/// </summary>
public class DatagramChannelCreator : SocketOption
{
[Obsolete(message:"Please use the method with AddressFamily parameter. Using this method will always return an IPv6 bound UDP endpoint.")]
public virtual Socket Create()
{
return new Socket(SocketType.Dgram, ProtocolType.Udp);
}

public virtual Socket Create(AddressFamily addressFamily)
{
return new Socket(addressFamily, SocketType.Dgram, ProtocolType.Udp);
Expand Down
6 changes: 0 additions & 6 deletions src/core/Akka/IO/Udp.cs
View file
Expand Up @@ -176,12 +176,6 @@ public NoAck(object token)
/// </summary>
public sealed class Send : Command
{
[Obsolete("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(ByteString, EndPoint, Event)` instead.")]
public Send(IEnumerator<ByteBuffer> payload, EndPoint target, Event ack)
: this(ByteString.FromBuffers(payload), target, ack)
{
}

/// <summary>
/// Creates a new send request to be executed via UDP socket to a addressed to the provided endpoint.
/// Once send completes, this request will acknowledged back on the sender side with an <paramref name="ack"/>
Expand Down
6 changes: 0 additions & 6 deletions src/core/Akka/IO/UdpConnected.cs
View file
Expand Up @@ -165,12 +165,6 @@ public NoAck(object token)
/// </summary>
public sealed class Send : Command
{
[Obsolete("Akka.IO.Udp.Send public constructors are obsolete. Use `Send.Create` or `Send(ByteString, EndPoint, Event)` instead.")]
public Send(IEnumerator<ByteBuffer> payload, Event ack)
: this(ByteString.FromBuffers(payload), ack)
{
}

/// <summary>
/// Creates a new send request to be executed via UDP socket to a addressed to an endpoint known by the connected UDP actor.
/// Once send completes, this request will acknowledged back on the sender side with an <paramref name="ack"/>
Expand Down
21 changes: 0 additions & 21 deletions src/core/Akka/IO/UdpSettings.cs
View file
Expand Up @@ -46,27 +46,6 @@ public static UdpSettings Create(Config config)
fileIoDispatcher: config.GetString("file-io-dispatcher", "akka.actor.default-dispatcher"));
}

// directBufferSize and maxDirectBufferPoolSize parameter are byterot, remove this in v1.5
[Obsolete("Please the constructor without directBufferSize and maxDirectBufferPoolSize parameter")]
public UdpSettings(
string bufferPoolConfigPath,
bool traceLogging,
int initialSocketAsyncEventArgs,
int directBufferSize,
int maxDirectBufferPoolSize,
int batchReceiveLimit,
string managementDispatcher,
string fileIoDispatcher)
: this(
bufferPoolConfigPath,
traceLogging,
initialSocketAsyncEventArgs,
batchReceiveLimit,
managementDispatcher,
fileIoDispatcher)
{
}

public UdpSettings(string bufferPoolConfigPath, bool traceLogging, int initialSocketAsyncEventArgs, int batchReceiveLimit, string managementDispatcher, string fileIoDispatcher)
{
BufferPoolConfigPath = bufferPoolConfigPath;
Expand Down

0 comments on commit 3ec5ea0

Please sign in to comment.