Skip to content

Commit

Permalink
Remove obsolete methods from Akka.Cluster.Tools (#6442)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Arkatufus
Arkatufus committed Feb 24, 2023
1 parent da1fceb commit 90e8770
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 46 deletions.
17 changes: 0 additions & 17 deletions src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedPubSubSettings.cs
View file
Expand Up @@ -109,23 +109,6 @@ public static DistributedPubSubSettings Create(Config config)
/// </summary>
public bool SendToDeadLettersWhenNoSubscribers { get; }

/// <summary>
/// Creates a new instance of the <see cref="DistributedPubSubSettings" />.
/// </summary>
/// <param name="role">The role that will host <see cref="DistributedPubSubMediator"/> instances.</param>
/// <param name="routingLogic">Optional. The routing logic used for distributing messages for topic groups.</param>
/// <param name="gossipInterval">The gossip interval for propagating topic/subscriber data to other mediators.</param>
/// <param name="removedTimeToLive">The amount of time it takes to prune a deactivated subscriber from the network.</param>
/// <param name="maxDeltaElements">The maximum number of delta elements that can be propagated in a single gossip tick.</param>
/// <exception cref="ArgumentException">Thrown if a user tries to use a <see cref="ConsistentHashingRoutingLogic"/> with routingLogic.</exception>
[Obsolete("Obsolete - please us the full constructor instead. This constructor only exists for backwards API compatibility.")]
public DistributedPubSubSettings(
string role,
RoutingLogic routingLogic,
TimeSpan gossipInterval,
TimeSpan removedTimeToLive,
int maxDeltaElements) : this(role, routingLogic, gossipInterval, removedTimeToLive, maxDeltaElements, true){ }

/// <summary>
/// Creates a new instance of the <see cref="DistributedPubSubSettings" />.
/// </summary>
Expand Down
14 changes: 0 additions & 14 deletions src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxySettings.cs
View file
Expand Up @@ -158,20 +158,6 @@ public ClusterSingletonProxySettings WithRole(string role)
return Copy(role: role);
}

/// <summary>
/// Creates a new <see cref="ClusterSingletonProxySettings" /> setting with the specified <paramref name="singletonIdentificationInterval"/>.
/// <note>
/// This method is immutable and returns a new instance of the setting.
/// </note>
/// </summary>
/// <param name="singletonIdentificationInterval">The identification level of the singleton proxy.</param>
/// <returns>A new setting with the provided <paramref name="singletonIdentificationInterval" />.</returns>
[Obsolete("For compatibility reasons only. Use method with TimeSpan parameter instead")]
public ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval)
{
return this;
}

/// <summary>
/// Creates a new <see cref="ClusterSingletonProxySettings" /> setting with the specified <paramref name="singletonIdentificationInterval"/>.
/// <note>
Expand Down
5 changes: 0 additions & 5 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Core.verified.txt
View file
Expand Up @@ -205,9 +205,6 @@ namespace Akka.Cluster.Tools.PublishSubscribe
}
public sealed class DistributedPubSubSettings : Akka.Actor.INoSerializationVerificationNeeded
{
[System.ObsoleteAttribute("Obsolete - please us the full constructor instead. This constructor only exists f" +
"or backwards API compatibility.")]
public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements) { }
public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements, bool sendToDeadLettersWhenNoSubscribers) { }
public System.TimeSpan GossipInterval { get; }
public int MaxDeltaElements { get; }
Expand Down Expand Up @@ -397,8 +394,6 @@ namespace Akka.Cluster.Tools.Singleton
public static Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings Create(Akka.Configuration.Config config, bool considerAppVersion) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithBufferSize(int bufferSize) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithRole(string role) { }
[System.ObsoleteAttribute("For compatibility reasons only. Use method with TimeSpan parameter instead")]
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(System.TimeSpan singletonIdentificationInterval) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonName(string singletonName) { }
}
Expand Down
5 changes: 0 additions & 5 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt
View file
Expand Up @@ -205,9 +205,6 @@ namespace Akka.Cluster.Tools.PublishSubscribe
}
public sealed class DistributedPubSubSettings : Akka.Actor.INoSerializationVerificationNeeded
{
[System.ObsoleteAttribute("Obsolete - please us the full constructor instead. This constructor only exists f" +
"or backwards API compatibility.")]
public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements) { }
public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements, bool sendToDeadLettersWhenNoSubscribers) { }
public System.TimeSpan GossipInterval { get; }
public int MaxDeltaElements { get; }
Expand Down Expand Up @@ -397,8 +394,6 @@ namespace Akka.Cluster.Tools.Singleton
public static Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings Create(Akka.Configuration.Config config, bool considerAppVersion) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithBufferSize(int bufferSize) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithRole(string role) { }
[System.ObsoleteAttribute("For compatibility reasons only. Use method with TimeSpan parameter instead")]
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(System.TimeSpan singletonIdentificationInterval) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonName(string singletonName) { }
}
Expand Down
5 changes: 0 additions & 5 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt
View file
Expand Up @@ -205,9 +205,6 @@ namespace Akka.Cluster.Tools.PublishSubscribe
}
public sealed class DistributedPubSubSettings : Akka.Actor.INoSerializationVerificationNeeded
{
[System.ObsoleteAttribute("Obsolete - please us the full constructor instead. This constructor only exists f" +
"or backwards API compatibility.")]
public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements) { }
public DistributedPubSubSettings(string role, Akka.Routing.RoutingLogic routingLogic, System.TimeSpan gossipInterval, System.TimeSpan removedTimeToLive, int maxDeltaElements, bool sendToDeadLettersWhenNoSubscribers) { }
public System.TimeSpan GossipInterval { get; }
public int MaxDeltaElements { get; }
Expand Down Expand Up @@ -397,8 +394,6 @@ namespace Akka.Cluster.Tools.Singleton
public static Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings Create(Akka.Configuration.Config config, bool considerAppVersion) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithBufferSize(int bufferSize) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithRole(string role) { }
[System.ObsoleteAttribute("For compatibility reasons only. Use method with TimeSpan parameter instead")]
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(string singletonIdentificationInterval) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonIdentificationInterval(System.TimeSpan singletonIdentificationInterval) { }
public Akka.Cluster.Tools.Singleton.ClusterSingletonProxySettings WithSingletonName(string singletonName) { }
}
Expand Down

0 comments on commit 90e8770

Please sign in to comment.