Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet binary wrongly in the repository #2440

Closed
SeanFarrow opened this issue Jan 6, 2017 · 2 comments
Closed

NuGet binary wrongly in the repository #2440

SeanFarrow opened this issue Jan 6, 2017 · 2 comments
Milestone

Comments

@SeanFarrow
Copy link
Contributor

Having spoken with @Aaronontheweb, it appears that the NuGet 3.4 binary has been erroneously commited in to the .NuGet folder of the repository.

I am proposing we remove this file along with the NuGet.targets and pull them from the users cache, ensuring that they are appropriately added to the .gitignore file.

The rationale behind this change would be that most developers have NuGet on there system already, and if they don't we can just refresh the file from the web. I'm happy to create a PR for this in the next few days.

@Danthar
Copy link
Member

Danthar commented Jan 11, 2017

Deleting the NuGet.targets breaks the build atm. But if you can resolve that. Go for it.
The simpler solution would be to only delete the NuGet.exe and add it to the .gitignore file (if its not in there already).
A PR is always welcome.

@SeanFarrow
Copy link
Contributor Author

The fact that removing the NuGet.targets file breaks the build means one or more projects is relying on the file. I'm looking at this currently, so should have something for you later today. Also, I'm sure this was in the .gitignore, so it shouldn't have been added in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants