Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor guidelines: need to write document explaining how to introduce wire format changes #5278

Closed
Tracked by #5461
Aaronontheweb opened this issue Sep 15, 2021 · 0 comments
Labels

Comments

@Aaronontheweb
Copy link
Member

An example of where I goofed and approved a wire format change that should have been handled differently:

Hi @Martin-Molinero - this looks like a new version --> old version breaking wire format change that we caused, and the reason why is because we standardized the the primitive type manifests because they varied between .NET Core and .NET Framework due to the breaking changes Microsoft introduced at the inception of .NET Core.

We're really sorry about this - we probably should have made this an opt-in feature some months after introducing this serializer so you wouldn't be hit with this issue during a live upgrade. The work around for this now is probably to either just bite the bullet and upgrade everything, or to override this serializer with the one from the v1.4.19 source code and drop it later.

Originally posted by @Aaronontheweb in #4989 (comment)

Need to write some contributor guidelines that explain how to do this safely so users don't run into wire format compatibility issues between upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant