When Ask<> called with timeout == TimeSpan zero, timeout is never risen nor argument exception is thrown

[procode-rd]

Version Information
Akka.NET 1.4.38
Which Akka.NET Modules? Akka

Describe the bug
In call to Ask extension method, passing timeout with value TimeSpan.Zero causes method to block indefinitely without throwing AskTimeoutException

To Reproduce

TimeSpan timeout = default;
IActorRef someActorRef = ...

someActorRef.Ask("SomeMessageWhatHasNoHandler", timeout);
// here execution thread will be blocked indefinitely. no exception (neither AskTimeoutException nor ArgumentException).

Expected behavior
Ask extension method will thrown ArgumentException with message disallowing to use zero.
OR
AskTimeoutException will be thrown immediately without allocating other objects in method.

I'd prefer first expectation as calling Ask with zero timeout contradicts any need to call of that method.
Usually this comes from code error (as in my case) from code dynamically fetching or calculating timeout.

Actual behavior
Thread is blocked indefinitely.

Screenshots

Environment
.NET Framework 4.8. Windows 10 64bit.

[Aaronontheweb]

We do allow Timespan.Infinite today by default, but we probably shouldn't allow Timespan.Zero. Ok, I think that should be easy to fix against the v1.4 branch.

[Arkatufus]

Fixing this is much more complicated than we thought, we'll try and a Roslyn Analyzer to catch this in the future.

[Aaronontheweb]

Changing the internals of Ask<T> to catch this had a lot of side effects even in our own test suite - so we think it's probably best to put a layer of Roslyn analysis on top as a solution instead, like @Arkatufus suggested.