Appears to be copy pasta in Docs.Tutorials - Tutorial4 #6342
Comments
F0b0s
added a commit
to F0b0s/akka.net
that referenced
this issue
Jan 10, 2023
|
@Aaronontheweb can you take a look, please? |
|
Why would we remove those tests if they're doing something functional? @F0b0s |
|
What's the real issue here, in other words? |
|
Some tests from I suppose that someone, who created the Tutorial4, took Tutorial3 as the base, added some tests but forgot to remove copied tests. And this tests are not used in documentation. So i decided to remove them. Final decision up to you. |
|
Aha - got it. |
Aaronontheweb
pushed a commit
that referenced
this issue
Jan 16, 2023
|
@F0b0s merged! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When i was looking #4116 i found that the same tests set probably was copy pasted for tutorial 4 and is not used by documentation.
Tutorial only use this references:
Tutorial4/DeviceGroupSpec.cs?name=group-query-integration-testBut
Tutorial4/DeviceGroupSpec.cshas a set of tests not included ingroup-query-integration-testregion and these tests are the same asTutorial3/DeviceGroupSpecbut without fixes from #4116.I think it would be better to delete these tests.
The text was updated successfully, but these errors were encountered: